Apply :endpoint option to Bucket#presigned_post #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Object#presigned_post` properly passes the bucket's url (which is affected by the `:endpoint` option), so to keep consistency we make `Bucket#presigned_post` pass it as well.
|
Related to #1012 |
|
Looks good with a first pass. |
|
Integration tests pass locally as well, and the behavior seems to match. Thanks! |
awood45
added a commit
that referenced
this pull request
Dec 5, 2015
Apply :endpoint option to Bucket#presigned_post Related to #1012
|
Thanks! Cool, I didn't know I've fixed an open issue. And I'm also the maintainer of Shrine which the opener mentions, it's cool how it's all connected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object#presigned_postproperly passes the bucket's url (which is affected by the:endpointoption), so to keep consistency we makeBucket#presigned_postpass it as well.